Should you pull on the upstroke when pedalling?

This seems to be a lot more controversial topic than I had believed. I personally mash my pedals most of the time but I’d always thought pulling on the upstroke was good.
Thoughts ?